Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe a misuse of plan_err #7879

Closed
waynexia opened this issue Oct 20, 2023 · 1 comment · Fixed by #7996
Closed

Maybe a misuse of plan_err #7879

waynexia opened this issue Oct 20, 2023 · 1 comment · Fixed by #7996
Assignees
@waynexia
Labels
bug Something isn't working

Comments

@waynexia
Copy link
Member

waynexia commented Oct 20, 2023 •
edited
Loading

Describe the bug

https://github.com/apache/arrow-datafusion/blob/37d6bf08c948418fe6c72d072d988c2875d81e02/datafusion/physical-expr/src/sort_expr.rs#L64-L73

This function (PhysicalSortExpr::evaluate_to_sort_column()) is in the execution phase. Errors at this stage should be exec_err! rather than plan_err!, right?

I also see other places have similar behavior and open this ticket to confirm. I'll submit a patch to change them if so.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
@waynexia waynexia added the bug Something isn't working label Oct 20, 2023
@alamb
Copy link
Contributor

alamb commented Oct 20, 2023

I agree this would be better as a execution_error

@waynexia waynexia self-assigned this Oct 23, 2023
@waynexia waynexia mentioned this issue Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waynexia waynexia

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

minor: change some plan_err to exec_err waynexia/arrow-datafusion
2 participants
@alamb @waynexia