-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISCUSS] Set DataFusion settings for maximum "out of the box" performance #6287
Comments
Here is another example of where we had to finagle settings to make DataFusion fast: #5942 |
Another example what I have found is increasing batch size solves some performance troubles related to excessive collection allocation or loops. I suppose there is also a trouble when the code gets triggered for empty batches, so the code spins CPU but in fact does nothing, I think noticed this behavior couple of times but need to have a good reproduce test to prove it. |
Thank you @alamb for putting this together. I definitely agree that we should choose the default configuration settings to squeeze maximum performance. OOTB performance is a common blogging subject, and search results that yield to such posts is a big entry to point to the user funnel. We should give users the right impression in terms of where Datafusion stands in terms of the performance. |
#6325 is another project to improve the performance out of the box |
Is your feature request related to a problem or challenge?
I want people's first impression of DataFusion to be "that is very fast" without having to tune parameters
DataFusion has many configuration options that control various performance optimization.
There is a tradeoff between some of these options between faster query execution (for more than linear resource consumption) and pure efficiency.
We have benchmarks such as a tpch runner that typically run with a single core. These are great as performance unit tests in well controlled environments (and avoid task overhead, and other non determinism introduced with multi-core execution), however they don't mimic what users typically run with.
Up to now we have taken a conservative approach and only enabled optimizations by default if they make everything faster. I would like to change our philosophy and optimize for "out of the box" performance
You can see examples of other systems tuning knobs up for performance:
IOx: https://github.com/influxdata/influxdb_iox/blob/ad28ebb7650d1cd21b995ee5b514d8da3580f22b/datafusion_util/src/config.rs#L20-L23
Here is a recent example from https://hussainsultan.com/posts/unbundled-datafusion/
Describe the solution you'd like
I would like to change the
ConfigOption
defaults to optimize performance in the common case rather than avoidperformance regressions in all cases
Specifically that means:
Describe alternatives you've considered
We can leave the defaults alone and make users change the defaults
Additional context
No response
The text was updated successfully, but these errors were encountered: