Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf serialization drops preserve_partitioning from SortExec #5305

Closed
thinkharderdev opened this issue Feb 16, 2023 · 0 comments · Fixed by #5306
Closed

Protobuf serialization drops preserve_partitioning from SortExec #5305

thinkharderdev opened this issue Feb 16, 2023 · 0 comments · Fixed by #5306
Labels
bug Something isn't working

Comments

@thinkharderdev
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

When SortExec is serialized to protobuf the preserve_partitioning flag is dropped and always set to false when deserializing.

To Reproduce
Steps to reproduce the behavior:

Do a round-trip serialization on a SortExec plan

Expected behavior
A clear and concise description of what you expected to happen.

The flag should be preserved in the serialized version

Additional context
Add any other context about the problem here.
@thinkharderdev thinkharderdev added the bug Something isn't working label Feb 16, 2023
@thinkharderdev thinkharderdev changed the title Protobug serialization drops preserve_partitioning from SortExec Protobuf serialization drops preserve_partitioning from SortExec Feb 16, 2023
@thinkharderdev thinkharderdev mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialize preserve_partitioning in SortExec coralogix/arrow-datafusion
1 participant
@thinkharderdev