Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join types to Python dataframe #495

Closed
Dandandan opened this issue Jun 3, 2021 · 0 comments · Fixed by #503
Closed

Add join types to Python dataframe #495

Dandandan opened this issue Jun 3, 2021 · 0 comments · Fixed by #503
Labels
enhancement New feature or request

Comments

@Dandandan
Copy link
Contributor

Dandandan commented Jun 3, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The Python dataframe code only supports inner, left, right. But we have outer, semi too and a PR open for anti join.

https://github.com/apache/arrow-datafusion/blob/master/python/src/dataframe.rs#L146

Describe the solution you'd like
Add mapping for outer, semi and anti to the join types.

Describe alternatives you've considered

Additional context
It might be useful to implement FromStr for the enum for this?

@Dandandan Dandandan added the enhancement New feature or request label Jun 3, 2021
@Dandandan Dandandan changed the title Add join types to Python Add join types to Python dataframe Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant