Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to determine whether to convert identifiers #4551

Closed
jiacai2050 opened this issue Dec 8, 2022 · 3 comments · Fixed by #5124
Closed

Add option to determine whether to convert identifiers #4551

jiacai2050 opened this issue Dec 8, 2022 · 3 comments · Fixed by #5124
Labels
enhancement New feature or request

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Dec 8, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

In CeresDB, we use datafusion for SQL execution, and find #1746 change unquoted identifiers to lowercase, which is a breaking change for us.

I agree with what #1746 does, but it there any possibilities to add an option to configure this? By default it will do the normalization, and users can choose not to do.

Describe the solution you'd like
Add on option to determine whether to convert identifiers.

If maintainers agree with this, I'd be glad to submit a PR.

Describe alternatives you've considered

Additional context

@jiacai2050 jiacai2050 added the enhancement New feature or request label Dec 8, 2022
@jiacai2050
Copy link
Contributor Author

@alamb Would you mind sharing your thoughts?

@alamb
Copy link
Contributor

alamb commented Jan 11, 2023

@jiacai2050 I think an option to control the case identifier behavior sounds very reasonable to me 👍

@jiacai2050
Copy link
Contributor Author

Thanks, I will open a PR to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants