Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serializing more deeply nested AND / OR expressions #4066

Closed
alamb opened this issue Nov 1, 2022 · 1 comment · Fixed by #4115
Closed

Support serializing more deeply nested AND / OR expressions #4066

alamb opened this issue Nov 1, 2022 · 1 comment · Fixed by #4115
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alamb
Copy link
Contributor

alamb commented Nov 1, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There are certain expressions that are "too complex" to serialize. After @crepererum 's fix in #3968 they at least produce a proper error

It would be nice to at least support deeply nested AND expression trees which are common in certain machine generated queries

Describe the solution you'd like
Ideally we would follow @andygrove 's suggestion (which I remember seeing but can't find) and rather than serializing an expression like

((A AND B) AND C) AND D ...

into a tree that matches the Expr structure, instead into a structure like

AndExpr(Vec<Expr>)

Describe alternatives you've considered
N/a

Additional context
See #3968 and https://github.com/influxdata/influxdb_iox/pull/6020

@alamb alamb added the enhancement New feature or request label Nov 1, 2022
@alamb alamb changed the title Support serializing more deeply nested expressions Support serializing more deeply nested AND / OR expressions Nov 1, 2022
@alamb alamb added the help wanted Extra attention is needed label Nov 1, 2022
@andygrove
Copy link
Member

Ideally we would follow @andygrove 's suggestion (which I remember seeing but can't find)

Here it is: #1434 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants