Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change from pub(super) or pub(crate) when reusing fns in aggregate.rs in window function implementations #373

Closed
jimexist opened this issue May 21, 2021 · 1 comment · Fixed by #1713
Closed

change from pub(super) or pub(crate) when reusing fns in aggregate.rs in window function implementations #373

jimexist opened this issue May 21, 2021 · 1 comment · Fixed by #1713
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jimexist
Copy link
Member

pub(super) or pub(crate) instead?

Originally posted by @jorgecarleitao in #334 (comment)
@jimexist jimexist mentioned this issue May 21, 2021
Merged
@jimexist jimexist added enhancement New feature or request good first issue Good for newcomers labels Nov 18, 2021
@HaoYang670
Copy link
Contributor

I'd like to have a try if no one has been doing it.

@HaoYang670 HaoYang670 mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add upper bound for public function signature HaoYang670/arrow-datafusion
2 participants
@jimexist @HaoYang670