Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GROUPING SETS syntax in SQL planner #2469

Closed
andygrove opened this issue May 6, 2022 · 2 comments · Fixed by #4770
Closed

Add support for GROUPING SETS syntax in SQL planner #2469

andygrove opened this issue May 6, 2022 · 2 comments · Fixed by #4770
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented May 6, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Issue #2378 adds support for ROLLUP and CUBE grouping sets. This is a follow on issue to also support GROUPING SETS, which may require changes to sqlparser-rs and also may require changes to the optimization rules to support Vec<Vec<Expr>>. See optimizer/utils.rs to see where this is not currently supported.

Describe the solution you'd like
Support GROUP BY foo, GROUPING SETS (a (b, c), (c, d, e))

Describe alternatives you've considered
None

Additional context
None

@alamb
Copy link
Contributor

alamb commented May 9, 2022

I agree changes to sqlparser-rs are required

@Jefffrey
Copy link
Contributor

To be closed by #4770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants