Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate subquery expressions #2361

Closed
Tracked by #2248
andygrove opened this issue Apr 27, 2022 · 4 comments
Closed
Tracked by #2248

Validate subquery expressions #2361

andygrove opened this issue Apr 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The SQL query planner and the DataFrame API both allow logical plans to be created that contain subquery expressions but we do not yet do any validation on these expressions.

Examples of validation we should do:

  • Scalar subqueries should return a single row and single column
  • IN subqueries should return a single column

Describe the solution you'd like
I am leaning towards performing this validation in an optimizer rule because that would be applied regardless of how the logical plan was created.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added the enhancement New feature or request label Apr 27, 2022
@jon-chuang
Copy link

@andygrove is there any reason why we can't support multiple columns in the IN subquery? As far as implementation goes, it's fairly trivial.

@mingmwang
Copy link
Contributor

I am working on it now.

@mingmwang
Copy link
Contributor

@jon-chuang
I think we do not support named Struct in DataFusion today.

@mingmwang
Copy link
Contributor

This issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants