Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsDistinctFrom/IsNotDistinctFrom for decimal type #1590

Open
liukun4515 opened this issue Jan 17, 2022 · 1 comment
Open

IsDistinctFrom/IsNotDistinctFrom for decimal type #1590

liukun4515 opened this issue Jan 17, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@liukun4515
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

part of #122
in the #122, we have supported the decimal type in datafusion, but for IsDistinctFrom、IsNotDistinctFrom we just convert the value to FLOAT64.

we should follow the mathematics operation for decimal type pull request #1483 and refactor these two operations.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@kmitchener
Copy link
Contributor

@liukun4515 this can be closed, right? proper comparison of decimal128 seems to be implemented and it's not converting to float64.

https://github.com/apache/arrow-rs/blob/master/arrow/src/util/decimal.rs#L163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants