Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call_ip in the SchedulerServer #1558

Closed
yahoNanJing opened this issue Jan 14, 2022 · 2 comments
Closed

Remove call_ip in the SchedulerServer #1558

yahoNanJing opened this issue Jan 14, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@yahoNanJing
Copy link
Contributor

Describe the bug

Currently there's a field in the SchedulerServer for recording caller ip which sends requests to the scheduler. However, for one scheduler, there will be multiple clients. Concurrency issue may occur. It's not a good way for record the requester info in a global field. Therefore, it's better to remove it from the SchedulerServer.

We can get the requester ip from the hyper info and set it to the tonic info. Then in each tonic-based grpc interface, we can get the the requester ip from the Request.

@yahoNanJing yahoNanJing added the bug Something isn't working label Jan 14, 2022
@drauschenbach
Copy link
Contributor

Resolved elsewhere. See #1559.

@alamb
Copy link
Contributor

alamb commented Nov 2, 2024

Thanks @drauschenbach

@alamb alamb closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants