function module in python binding is broken in 6.0

[jimexist]

Describe the bug

the function module in python binding is broken in 6.0

To Reproduce

In [1]: import datafusion
f
In [2]: from datafusion import functions

In [3]: dir(functions)
Out[3]:
['__builtins__',
 '__cached__',
 '__doc__',
 '__file__',
 '__getattr__',
 '__loader__',
 '__name__',
 '__package__',
 '__spec__',
 'functions']

Expected behavior

expect the function module to be only one level below Datafusion.

Additional context

related

1. Rework the python bindings [WIP] #856
2. Rework the python bindings using conversion traits from arrow-rs  #873

[houqp]

@jimexist this was intentional, see #1287 (comment).

[houqp]

I don't have a strong opinion on this though, if you think there is a valid use-case for having the functions module, we can add it back.

[houqp]

#1287 (comment) is the comment that made me change my mind on my original PR :)

[jimexist]

I don't have a strong opinion on this though, if you think there is a valid use-case for having the functions module, we can add it back.

so you are saying that we should use:

 from datafusion.functions import functions as f

instead of

 from datafusion import functions as f

having two layers of functions is unintuitive

[jimexist]

ah I see now that I can do

from datafusion.functions import md5

[houqp]

from datafusion import functions as f should still work, it's just that datafusion.functions won't work anymore.

[houqp]

oh, i see what confused you. yeah, it would be better if dir works with functions module :(