Implement Specialized GroupColumn
for Date
/Time
/Timestamp
types for multi-column GROUP BY
#13263
Labels
enhancement
New feature or request
Is your feature request related to a problem or challenge?
In #12269 @jayzhan211 made significant improvements to how group values are stored in multi-column aggregations.
Specifically for queries like
The improvement relies on implementing specialized versions of
GroupColumn
for the types ofcol1
,colN
We have implemented the primitive types and Strings/StringViews now, but we have not implemented all types
This means queries like
Will fall back to the slower (but general)
GroupValuesRows
:datafusion/datafusion/physical-plan/src/aggregates/group_values/row.rs
Lines 40 to 41 in a6586cc
Describe the solution you'd like
Implement
GroupColumn
for all primitive types.You can see how to do this here:
datafusion/datafusion/physical-plan/src/aggregates/group_values/mod.rs
Lines 117 to 121 in e4bd579
and the make sure there are tests for each of those types in queries that group on multiple columns
Describe alternatives you've considered
No response
Additional context
Here is an example for how this was done for Strings: #12809
The text was updated successfully, but these errors were encountered: