Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date_bin: incorrect binning at date_bin boundaries before the epoch #13145

Closed
mhilton opened this issue Oct 28, 2024 · 3 comments · Fixed by #13204
Closed

date_bin: incorrect binning at date_bin boundaries before the epoch #13145

mhilton opened this issue Oct 28, 2024 · 3 comments · Fixed by #13204
Assignees
Labels
bug Something isn't working

Comments

@mhilton
Copy link
Contributor

mhilton commented Oct 28, 2024

Describe the bug

For times before the unix epoch (1970-01-01T00:00:00) times at the boundary are incorrectly put into the previous time bin.

To Reproduce

In datafusion-cli:

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:00') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T18:59:30 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.002 seconds.

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:30') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T19:00:00 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.001 seconds.

Expected behavior

A time at the date_bin boundary to be in the correct bin:

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:00') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T19:00:00 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.002 seconds.

> SELECT date_bin(INTERVAL '30 second', '1969-12-31T19:00:30') as t;
+---------------------+
| t                   |
+---------------------+
| 1969-12-31T19:00:30 |
+---------------------+
1 row(s) fetched. 
Elapsed 0.001 seconds.

Additional context

No response

@mhilton mhilton added the bug Something isn't working label Oct 28, 2024
@Omega359
Copy link
Contributor

Possibly related: #10602

@alamb
Copy link
Contributor

alamb commented Oct 29, 2024

I believe that @itsjunetime is planning to look into this one

@itsjunetime
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants