Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ORDER BY in Substrait aggregate functions #13113

Closed
bvolpato opened this issue Oct 25, 2024 · 1 comment · Fixed by #13114
Closed

Support ORDER BY in Substrait aggregate functions #13113

bvolpato opened this issue Oct 25, 2024 · 1 comment · Fixed by #13114
Assignees
@bvolpato
Labels
enhancement New feature or request

Comments

@bvolpato
Copy link
Contributor

Is your feature request related to a problem or challenge?

There is proper decoding of Substrait into aggregate functions in DataFusion, but it silently drops any sort fields from the original plan.

Looking at the plan: https://github.com/apache/datafusion/blob/main/datafusion/substrait/src/logical_plan/consumer.rs#L716-L726, it was left as a TODO when implemented:

// TODO: Add parsing of order_by also

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

I plan to take a stab at this.
@bvolpato bvolpato added the enhancement New feature or request label Oct 25, 2024
@bvolpato bvolpato mentioned this issue Oct 25, 2024
Merged
@bvolpato
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvolpato bvolpato

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(substrait): support order_by in aggregate functions bvolpato/datafusion
1 participant
@bvolpato