Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the name function in datafusion #11782

Open
jayzhan211 opened this issue Aug 2, 2024 · 1 comment
Open

Simplify the name function in datafusion #11782

jayzhan211 opened this issue Aug 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Aug 2, 2024

Is your feature request related to a problem or challenge?

There are display_name, create_name, write_name, impl fmt::Display for Expr, create_function_physical_name, create_physical_name, physical_name..

I hope we can have much more simplified and easy to use name function.
If we can standardize logical namd and physical name is a big plus. IIRC, the only expression that has gap between logical and physical name is Cast, and we probably do not need to.

This could also help #10274 a lot

Describe the solution you'd like

ideally we could keep impl fmt::Display for Expr and use format!() to get the String for display_name🤔
And, minimize the gap between logical name and physical name.

Describe alternatives you've considered

No response

Additional context

#11724 (comment)

@lewiszlw
Copy link
Member

lewiszlw commented Aug 4, 2024

These name functions confused me a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants