Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure column names are equivalent with or without optimization #1123

Closed
matthewmturner opened this issue Oct 15, 2021 · 2 comments
Closed

Comments

@matthewmturner
Copy link
Contributor

matthewmturner commented Oct 15, 2021

In the context of adding a new physical optimizer (#1063) the topic of column names came up. From this, we would like to ensure that regardless of whether an optimization was performed that the output column name is the same.

I believe we will want to add tests for this that simply check output schemas of a plan that wasnt optimized and an optimized plan.

These tests could likely belong in datafusion/tests/optimizer.rs which we expect to make as part of #1118

Originally posted by @rdettai in #1063 (comment)

@rdettai
Copy link
Contributor

rdettai commented Oct 15, 2021

Could you please provide a more detailed write up for this issue? If it is picked up by someone else than us or in a few months, not sure he/we'll be able to figure out what this is about 😄

@alamb
Copy link
Contributor

alamb commented Dec 6, 2022

I think @jackwener fixed this one in #4233

@alamb alamb closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants