-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop changing the case for COPY TO option values #10853
Comments
fyi @metesynnada |
Sorry if I mislead you. I encountered this issue in the datafusion/datafusion/sql/src/statement.rs Lines 1017 to 1025 in 3773fb7
How has such an issue typically been resolved previously? If adding a datafusion/datafusion/sql/src/planner.rs Lines 97 to 100 in 47026a2
|
I believe we can remove the lowercase conversion here and instead add it when we set |
If no one else is working on this issue, I'll take it. My plan is to remove the automatic conversion of values to lowercase and to create a lookup table for keys. This table will indicate the specific standardization methods. |
Another potential option is to follow the model of the I don't remember wll the usecases for configuration option case sensitivity, so please ignore this suggestion if it doesn't make sense |
I draft #11330 to discuss this. Let me know your thoughts! |
Describe the bug
Currently, we're changing the case of every option value passed with the COPY statement:
datafusion/datafusion/sql/src/statement.rs
Lines 891 to 900 in 3773fb7
This causes an issue in cases where the option values for some external integrations might be case sensitive (eg. like access keys).
@xinlifoobar found this while working on adding an integration to huggingface in #10792.
See previous discussion here: #9723 (comment)
To Reproduce
No response
Expected behavior
There should be some way to pass option values as is for certain integrations.
Additional context
No response
The text was updated successfully, but these errors were encountered: