Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowercase name for aggregate function #10695

Closed
alamb opened this issue May 28, 2024 · 3 comments · Fixed by #10696
Closed

Use lowercase name for aggregate function #10695

alamb opened this issue May 28, 2024 · 3 comments · Fixed by #10696
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented May 28, 2024

Is your feature request related to a problem or challenge?

first_value and last_value window functions currently report their names as FIRST_VALUE but also have a lower case alias:

aliases: vec![String::from("first_value")],

part of #8708

Describe the solution you'd like

I think we would like to avoid the aliases and simply have a single name, similarly how the other functions work

TODO

  • Count

Describe alternatives you've considered

No response

Additional context

No response

@jayzhan211
Copy link
Contributor

jayzhan211 commented May 30, 2024

I think we need to rename other builtin aggregate function to lowercase too.

@jayzhan211 jayzhan211 reopened this May 30, 2024
@jayzhan211 jayzhan211 changed the title Remove redundant upper case aliases for FIRST_VALUE and LAST_VALUE Use lowercase name for aggregate function May 30, 2024
@edmondop
Copy link
Contributor

This might be solved too? @alamb

@jayzhan211
Copy link
Contributor

Yeah, solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants