Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assertions with error macros #10232

Open
comphead opened this issue Apr 25, 2024 · 0 comments
Open

Replace assertions with error macros #10232

comphead opened this issue Apr 25, 2024 · 0 comments

Comments

@comphead
Copy link
Contributor

There are some places in Datafusion doing assertions which leads the application to crash. Its better to replace assertions with error wherever possible

Example: assert_eq! here to keep it consistent with other implementations of GroupsAccumulator. Eg. see here among others:
https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/aggregate/groups_accumulator/prim_op.rs?plain=1#L93

Originally posted by @lkt in #10149 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant