Fix clippy

apache · Dec 29, 2023 · 56c3919 · 56c3919
1 parent e05123a
commit 56c3919
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/datafusion/core/src/physical_optimizer/enforce_distribution.rs b/datafusion/core/src/physical_optimizer/enforce_distribution.rs
@@ -1410,7 +1410,7 @@ impl DistributionContext {
 
 impl TreeNode for DistributionContext {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children_nodes.iter().map(|c| c.clone()).collect()
+        self.children_nodes.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>
@@ -1474,7 +1474,7 @@ impl PlanWithKeyRequirements {
 
 impl TreeNode for PlanWithKeyRequirements {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children.iter().map(|c| c.clone()).collect()
+        self.children.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>

diff --git a/datafusion/core/src/physical_optimizer/enforce_sorting.rs b/datafusion/core/src/physical_optimizer/enforce_sorting.rs
@@ -146,7 +146,7 @@ impl PlanWithCorrespondingSort {
 
 impl TreeNode for PlanWithCorrespondingSort {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children_nodes.iter().map(|c| c.clone()).collect()
+        self.children_nodes.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>
@@ -227,7 +227,7 @@ impl PlanWithCorrespondingCoalescePartitions {
 
 impl TreeNode for PlanWithCorrespondingCoalescePartitions {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children_nodes.iter().map(|c| c.clone()).collect()
+        self.children_nodes.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>

diff --git a/datafusion/core/src/physical_optimizer/pipeline_checker.rs b/datafusion/core/src/physical_optimizer/pipeline_checker.rs
@@ -92,7 +92,7 @@ impl PipelineStatePropagator {
 
 impl TreeNode for PipelineStatePropagator {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children.iter().map(|c| c.clone()).collect()
+        self.children.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>

diff --git a/datafusion/core/src/physical_optimizer/replace_with_order_preserving_variants.rs b/datafusion/core/src/physical_optimizer/replace_with_order_preserving_variants.rs
@@ -105,7 +105,7 @@ impl OrderPreservationContext {
 
 impl TreeNode for OrderPreservationContext {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children_nodes.iter().map(|c| c.clone()).collect()
+        self.children_nodes.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>

diff --git a/datafusion/core/src/physical_optimizer/sort_pushdown.rs b/datafusion/core/src/physical_optimizer/sort_pushdown.rs
@@ -72,7 +72,7 @@ impl SortPushDown {
 
 impl TreeNode for SortPushDown {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children_nodes.iter().map(|c| c.clone()).collect()
+        self.children_nodes.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>

diff --git a/datafusion/expr/src/tree_node/plan.rs b/datafusion/expr/src/tree_node/plan.rs
@@ -23,7 +23,7 @@ use datafusion_common::{tree_node::TreeNode, Result};
 
 impl TreeNode for LogicalPlan {
     fn children_nodes(&self) -> Vec<Self> {
-        self.inputs().into_iter().map(|p| p.clone()).collect()
+        self.inputs().into_iter().cloned().collect()
     }
 
     fn apply<F>(&self, op: &mut F) -> Result<VisitRecursion>

diff --git a/datafusion/physical-expr/src/sort_properties.rs b/datafusion/physical-expr/src/sort_properties.rs
@@ -174,7 +174,7 @@ impl ExprOrdering {
 
 impl TreeNode for ExprOrdering {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children.iter().map(|c| c.clone()).collect()
+        self.children.to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>

diff --git a/datafusion/physical-expr/src/utils/mod.rs b/datafusion/physical-expr/src/utils/mod.rs
@@ -155,7 +155,7 @@ impl<T> ExprTreeNode<T> {
 
 impl<T: Clone> TreeNode for ExprTreeNode<T> {
     fn children_nodes(&self) -> Vec<Self> {
-        self.children().iter().map(|c| c.clone()).collect()
+        self.children().to_vec()
     }
 
     fn map_children<F>(mut self, transform: F) -> Result<Self>