Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOIN should require ON condition #1550

Open
demetribu opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1552
Open

JOIN should require ON condition #1550

demetribu opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1552

Comments

@demetribu
Copy link
Contributor

Describe the bug

SELECT ... FROM l JOIN r is not a valid SQL query, the ON condition should not be optional

Additional context

apache/datafusion#13486
@demetribu
Copy link
Contributor Author

take

@demetribu demetribu linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: JOIN should require ON condition demetribu/sqlparser-rs
1 participant
@demetribu