Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Struct datatype parsing for GenericDialect #1240

Closed
duongcongtoai opened this issue Apr 28, 2024 · 3 comments · Fixed by #1241
Closed

Support Struct datatype parsing for GenericDialect #1240

duongcongtoai opened this issue Apr 28, 2024 · 3 comments · Fixed by #1241

Comments

@duongcongtoai
Copy link
Contributor

Current BigQueryDialect is capable of parsing struct data type such as

create table t (s struct<n int, s varchar>);

According to README, this feature should also support GenericDialect, however in current code, before parsing this syntax, we only allow BigQueryDialect to have this syntax

@jayzhan211
Copy link
Contributor

Can we also support syntax with '()', like create table t (s struct(n int, s varchar)); like duckdb

@duongcongtoai
Copy link
Contributor Author

@alamb
Copy link
Contributor

alamb commented May 1, 2024

@duongcongtoai filed #1245 as a follow on. THank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants