Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Upgrade to Datafusion 37 #663

Closed
3 tasks done
Michael-J-Ward opened this issue May 1, 2024 · 1 comment · Fixed by #669
Closed
3 tasks done

Tracking Upgrade to Datafusion 37 #663

Michael-J-Ward opened this issue May 1, 2024 · 1 comment · Fixed by #669

Comments

@Michael-J-Ward
Copy link
Contributor

Michael-J-Ward commented May 1, 2024

I sketched out some of the upgrade in #662 and wanted to share what I encountered.

Some major changes in between datafusion 36 and 37.

Needs Completing

  • 1) Porting functions.rs BuiltInFunctons to datafusion-functions
  • 2) Replacing SectionContext::tables or updating the tests to not rely on it
  • 3) new trait methods for ExecutionPlan and ExecutionPlanProperties for DatasetExec need implementing

1) Porting BuiltinFunctions

See this epic apache/datafusion#9285.

That means much of datafusion-python::functions.rs needs an update. An incomplete first pass is 83249fe

2) SectionContext::tables

It was removed in apache/datafusion#9627

Many of the tests rely on this method. Does each test get updated to a new API or do we implement our own version to start and then update the tests until it's not necessary?

3) New Trait Methods

I just marked these as TODO to get the upgrade to compile. See 8cd4fd4

@Michael-J-Ward
Copy link
Contributor Author

Current Status

The initial steps are completed and python -m pytest now passing in #662 (modulo 1, discussed below).

TODO

Besides the failing test

  • Debug last failing test from porting BuiltinFunctions: ecff357
  • Decide if re-implementing SessionContext::tables is what we want to do
  • (maybe?) Remove allow(deprecated) from udf.rs
  • (maybe?) Ensure full test coverage of ported functions.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant