Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust / Check Cargo.toml formatting (amd64, stable) (pull_request) Failing #662

Closed
jiangzhx opened this issue Feb 9, 2023 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@jiangzhx
Copy link
Contributor

jiangzhx commented Feb 9, 2023

Describe the bug
Rust / Check Cargo.toml formatting (amd64, stable) (pull_request) Failing

To Reproduce
submit a pr.

@jiangzhx jiangzhx added the bug Something isn't working label Feb 9, 2023
@thinkharderdev
Copy link
Contributor

FYI Fixed this in #658. If that PR cannot be merged shortly (it's rather large) then we can pull into a separate one

@jiangzhx
Copy link
Contributor Author

FYI Fixed this in #658. If that PR cannot be merged shortly (it's rather large) then we can pull into a separate one

it's my pr #661 .

still got error on github action https://github.com/apache/arrow-ballista/actions/runs/4140311128/jobs/7159094110#step:8:1

@thinkharderdev
Copy link
Contributor

FYI Fixed this in #658. If that PR cannot be merged shortly (it's rather large) then we can pull into a separate one

it's my pr #661 .

still got error on github action https://github.com/apache/arrow-ballista/actions/runs/4140311128/jobs/7159094110#step:8:1

Right, #658 would have to be merged or you can just cherry-pick the commit with the fix.

@andygrove
Copy link
Member

Just fyi, DataFusion had the same issue and resolved it: apache/datafusion#5180

@jiangzhx
Copy link
Contributor Author

thanks everyone,it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants