From 160d238313be2d725c656efdaaef103063083d0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Raphael=20von=20der=20Gr=C3=BCn?= Date: Thu, 30 Aug 2018 15:55:49 +0200 Subject: [PATCH 1/3] Update ESLint and fix linting errors --- package.json | 12 ++++++------ src/cli.js | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index f0df101c7..bef04d0d2 100644 --- a/package.json +++ b/package.json @@ -40,13 +40,13 @@ "update-notifier": "0.5.0" }, "devDependencies": { - "eslint": "^4.0.0", - "eslint-config-semistandard": "^11.0.0", - "eslint-config-standard": "^10.2.1", + "eslint": "^5.4.0", + "eslint-config-semistandard": "^12.0.1", + "eslint-config-standard": "^11.0.0", "eslint-plugin-import": "^2.3.0", - "eslint-plugin-node": "^5.0.0", - "eslint-plugin-promise": "^3.5.0", - "eslint-plugin-standard": "^3.0.1", + "eslint-plugin-node": "^7.0.1", + "eslint-plugin-promise": "^4.0.0", + "eslint-plugin-standard": "^4.0.0", "istanbul": "^0.4.5", "jasmine": "^2.5.2", "rewire": "^2.5.2" diff --git a/src/cli.js b/src/cli.js index f24ea01a5..718b127fa 100644 --- a/src/cli.js +++ b/src/cli.js @@ -76,7 +76,7 @@ var shortHands = { function checkForUpdates () { try { // Checks for available update and returns an instance - var notifier = updateNotifier({pkg: pkg}); + var notifier = updateNotifier({ pkg: pkg }); if (notifier.update && notifier.update.latest !== pkg.version) { From 193ba72d1b54d965181a8ef9d1630cb20103f668 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Raphael=20von=20der=20Gr=C3=BCn?= Date: Thu, 30 Aug 2018 15:57:06 +0200 Subject: [PATCH 2/3] Update dependencies Staying on jasmine 3.1.x for now. See: https://github.com/apache/cordova-lib/pull/639 --- package.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index bef04d0d2..3cff04b29 100644 --- a/package.json +++ b/package.json @@ -30,14 +30,14 @@ "cli" ], "dependencies": { - "configstore": "2.1.0", + "configstore": "^4.0.0", "cordova-common": "^2.2.0", "cordova-lib": "8.0.0", "editor": "1.0.0", "insight": "0.8.4", "loud-rejection": "^1.6.0", - "nopt": "3.0.1", - "update-notifier": "0.5.0" + "nopt": "^4.0.1", + "update-notifier": "^2.5.0" }, "devDependencies": { "eslint": "^5.4.0", @@ -48,8 +48,8 @@ "eslint-plugin-promise": "^4.0.0", "eslint-plugin-standard": "^4.0.0", "istanbul": "^0.4.5", - "jasmine": "^2.5.2", - "rewire": "^2.5.2" + "jasmine": "^3.1.0", + "rewire": "^4.0.1" }, "author": "Anis Kadri", "contributors": [ From 2e126908b5fe1a057b0658929aad4ee3d238578f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Raphael=20von=20der=20Gr=C3=BCn?= Date: Thu, 30 Aug 2018 19:18:40 +0200 Subject: [PATCH 3/3] Update `insight` to resolve `npm audit` warning - To resolve the lodash warning, 0.9.0 would have sufficed. - Because of https://github.com/yeoman/insight/commit/dae6dd4b73b9 users will be asked again whether they want data to be collected Fixes #300 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3cff04b29..f2a2f36b4 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ "cordova-common": "^2.2.0", "cordova-lib": "8.0.0", "editor": "1.0.0", - "insight": "0.8.4", + "insight": "^0.10.1", "loud-rejection": "^1.6.0", "nopt": "^4.0.1", "update-notifier": "^2.5.0"