Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordova create creates outdated res folder #404

Closed
janpio opened this issue Feb 13, 2019 · 4 comments
Closed

cordova create creates outdated res folder #404

janpio opened this issue Feb 13, 2019 · 4 comments

Comments

@janpio
Copy link
Member

janpio commented Feb 13, 2019

When I use cordova create to create a new project, I also get a res folder that has loads of outdated screens and icons:

E:.
├───icon
│   ├───android
│   ├───bada
│   ├───bada-wac
│   ├───blackberry
│   ├───blackberry10
│   ├───ios
│   ├───tizen
│   ├───webos
│   └───windows-phone
└───screen
    ├───android
    ├───bada
    ├───bada-wac
    ├───blackberry
    ├───blackberry10
    ├───ios
    ├───tizen
    ├───webos
    └───windows-phone

The README in the folder ironically says:

Note that these image resources are not copied into a project when a project
is created with the CLI. Although there are default image resources in a
newly-created project, those come from the platform-specific project template,
which can generally be found in the platform's `template` directory. Until
icon and splashscreen support is added to the CLI, these image resources
aren't used directly.

See https://issues.apache.org/jira/browse/CB-5145

I couldn't figure out where both the files and the README are coming from.

  • The files for the deprecated platforms could be removed
  • The README should be updated

(Fresh install of 8.1.2 ([email protected]))

@janpio
Copy link
Member Author

janpio commented Feb 13, 2019

Turns out this was already removed in Mai 2018: apache/cordova-app-hello-world#21 Current version of that repo is 4.0.0, which was tagged/released in December 2018 - so I don't really understand why I am getting an older version on project creation.

Is the version pinned maybe to an older one?

@janpio
Copy link
Member Author

janpio commented Feb 13, 2019

Yep, seems so: https://github.com/apache/cordova-create/blame/f85490a9e2ce44bf93a4d0dc688d85ac863d0e8b/package.json#L28 This was only changed 2 months ago, but the CLI I am using is probably using a version that does not include those changes yet.

So can I assume that the problem will be fixed with/in Cordova 9 @erisu?

@brodycj
Copy link
Contributor

brodycj commented Feb 13, 2019

https://github.com/apache/cordova-create/blame/f85490a9e2ce44bf93a4d0dc688d85ac863d0e8b/package.json#L28

The change in apache/cordova-create@4c27309 was part of [email protected] but cordova-lib still seems to be at cordova-create@1: https://github.com/apache/cordova-lib/blob/54a9b3d0670d1c8217024ec1e9fc23b9ae428a6e/package.json#L21

So can I assume that the problem will be fixed with/in Cordova 9 @erisu?

Yes. We have not yet reached the stage of preparing cordova-lib for Cordova 9 in apache/cordova#10.

@janpio
Copy link
Member Author

janpio commented Feb 13, 2019

Thanks for confirming @brodybits. (These dependency chains are breaking my brain.)

Will be great to have that change out there.

@janpio janpio closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants