Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test failure with shebang interpreter in rewired files #939

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 1, 2020

Motivation and Context

fixes: #938

Bin files that contains the shebang interpreter fails when being rewired.

Description

  • Remove shebang from logical files that do not need it.
  • Move version logic into Api.js and stop requiring the bin file

Testing

  • npm t
  • cordova create
  • cordova platform add android
  • cordova build android
  • cordova run android
  • cordova prepare android
  • Create platform though Platform-Centered workflow

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@erisu erisu added this to the 9.0.0 milestone Apr 1, 2020
@erisu erisu requested review from timbru31 and breautek April 1, 2020 02:49
@erisu erisu merged commit fb26050 into apache:master Apr 1, 2020
@erisu erisu deleted the test/shebang branch April 1, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are broken on NodeJS 12.16.0+
2 participants