fix: remove pollOnce from NativeToJsMessageQueue.popAndEncodeAsJs #1746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove the require block for
cordova/plugin/android/polling
, a module that doesn't exist.Resolves #1735
Description
The
cordova/plugin/android/polling
module appears to have been removed since 2012.The last known version of Cordova-JS where this module existed was [email protected] - polling.js in the
polling.js
file, with the version tag created on Sep 13, 2012.The module was removed in
[email protected]
, a tag/release created on Oct 16, 2012.The exact commit that removed the module from Cordova-JS does not have an associated PR, GitHub issue, or CB ticket to explain the reason for this change.
Additionally, the platform-specific Cordova-JS modules, which reside in the
cordova-js-src
directory of this repository (originally labeled asplatform_modules
), were not created until 2015—2 years and 4 months later. This directory has also never contained the polling module as far as I can see.Since this part of the code has not been functional since 2012, I believe it is safe to remove it.
Testing
n/a
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)