Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createUser/updateUser APIs need to be POST #85

Open
mlsorensen opened this issue May 6, 2024 · 3 comments
Open

createUser/updateUser APIs need to be POST #85

mlsorensen opened this issue May 6, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mlsorensen
Copy link
Contributor

mlsorensen commented May 6, 2024

if a.Name == "deployVirtualMachine" || a.Name == "login" || a.Name == "updateVirtualMachine" {

The generation code uses post calls for a subset of APIs that are sensitive or large. Eventually the listApis should advertise which APIs these are, but until then we need to switch these createUser and updateUser calls (and any other that may send sensitive info) over to use POST.

@rohit-satya
Copy link

@mlsorensen Please assign this to me

@shwstppr
Copy link
Contributor

shwstppr commented May 9, 2024

@rohit-satya there is already a PR for this now, #86. You may help review/test that

@phsm
Copy link

phsm commented Nov 6, 2024

Perhaps this issue can be closed as the referenced PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants