Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CAMEL_K_TEST_SKIP_PROBLEMATIC flag #5484

Closed
squakez opened this issue May 9, 2024 · 1 comment · Fixed by #5606
Closed

Remove CAMEL_K_TEST_SKIP_PROBLEMATIC flag #5484

squakez opened this issue May 9, 2024 · 1 comment · Fixed by #5606
Labels
area/continuous integration Related to CI and automated testing area/openshift Related to OpenShift area/test good first issue Does not require full understanding of the codebase
Milestone
2.4.0

Comments

@squakez
Copy link
Contributor

squakez commented May 9, 2024 •
edited
Loading

For some reason, in the past, this flag was introduced as we were not able to solve certain checks failing in Openshift (likely in certain downstream builds). This can be misleading, as all tests are meant to work correctly in upstream CI. If some check is failing in any Kubernetes distribution, we should instead identify the root cause and solve it.

I advocate to remove the flag and all inherent to it, and bubble up any problem in order to be properly addressed instead of leaving it unattended for years (like it is happening now).
@squakez squakez added area/continuous integration Related to CI and automated testing area/test area/openshift Related to OpenShift labels May 9, 2024
@squakez
Copy link
Contributor Author

squakez commented May 9, 2024

cc @lburgazzoli

@squakez squakez mentioned this issue May 9, 2024
Closed
@squakez squakez added the good first issue Does not require full understanding of the codebase label May 9, 2024
@squakez squakez added this to the 2.4.0 milestone May 9, 2024
@jonomorris jonomorris mentioned this issue Jun 8, 2024
Merged
@squakez squakez linked a pull request Jun 10, 2024 that will close this issue
Remove CAMEL_K_TEST_SKIP_PROBLEMATIC flag and problematic reporting #5606
Merged
@gansheer gansheer mentioned this issue Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/continuous integration Related to CI and automated testing area/openshift Related to OpenShift area/test good first issue Does not require full understanding of the codebase
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Remove CAMEL_K_TEST_SKIP_PROBLEMATIC flag and problematic reporting
1 participant
@squakez