Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload local dependencies as maven artifact #4244

Closed
squakez opened this issue Apr 12, 2023 · 5 comments
Closed

Upload local dependencies as maven artifact #4244

squakez opened this issue Apr 12, 2023 · 5 comments

Comments

@squakez
Copy link
Contributor

squakez commented Apr 12, 2023

With #1227 we've enabled the possibility to use local dependencies. However, the mechanism seems to be working only using "spectrum" strategy which won't let certain cluster (ie, OCP) to have the feature fully available. We are also performing this operation on the client side, which I think it create a certain coupling we need to avoid.

I wonder if we can rethink the implementation of the feature differently. I am thinking we could upload the dependency to the operator Pod and delegate to it the deployment to the local maven repo using the maven deploy:deploy [1]. As in version 2 we have a storage that will keep the dependencies, it could be a possible strategy to adopt.

[1] https://maven.apache.org/guides/mini/guide-3rd-party-jars-remote.html

@squakez
Copy link
Contributor Author

squakez commented Apr 12, 2023

@johnpoth wdyt?

@johnpoth
Copy link
Member

Hi @squakez ! Great idea! I tested this against OCP in the past and it worked but it was a long time ago... will try to give it another try at some point....

How would the dependency be uploaded ? Via SCP? What is the storage planned for version 2 (haven't seen it mentioned in the roadmap)?

@squakez
Copy link
Contributor Author

squakez commented Apr 24, 2023

Hello. The storage implemantation was described in #3831 - about the possibility to upload to the operator, it's an implementation detail I haven't taken in consideration yet. I was thinking at high level details, where the CLI (or even directly the kubectl) would upload the dependency with the compatible kube mechanisms, and from there, the operator would deploy to its local maven repo.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez
Copy link
Contributor Author

squakez commented Jul 26, 2023

This one probably does not make sense any longer. We should promote the usage of a Maven repository [1], in which case, uploading a dependency should be done over the repository.

[1] https://camel.apache.org/blog/2023/06/camel-k-maven-proxy/

@squakez squakez closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants