Fixed locking of PendingAddOp #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3806 +/- ##
============================================
+ Coverage 60.47% 68.31% +7.83%
- Complexity 5847 6744 +897
============================================
Files 473 473
Lines 40933 40934 +1
Branches 5235 5235
============================================
+ Hits 24756 27965 +3209
+ Misses 13976 10712 -3264
- Partials 2201 2257 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eolivelli
reviewed
Feb 25, 2023
There was a problem hiding this comment.
Usually these methods are always called on the same thread.
Adding synchronized under this assumptium shouldn't add much cost (no actual contention) so I am fine with the patch.
I wonder if you found out which is the activity who accesses this object outside of the assigned ML thread
eolivelli
approved these changes
Feb 25, 2023
hangc0276
reviewed
Feb 26, 2023
| @@ -358,7 +358,7 @@ public synchronized void writeComplete(int rc, long ledgerId, long entryId, Book | |||
| } else { | |||
| LOG.warn("Failed to write entry ({}, {}) to bookie ({}, {}): {}", | |||
| ledgerId, entryId, bookieIndex, addr, BKException.getMessage(rc)); | |||
| lh.handleBookieFailure(ImmutableMap.of(bookieIndex, addr)); | |||
| lh.executeOrdered(() -> lh.handleBookieFailure(ImmutableMap.of(bookieIndex, addr))); | |||
There was a problem hiding this comment.
We shouldn't change the thread here, it will delay the handleBookieFailure process. Please check the failed test LedgerClose2Test#testMetadataChangedDuringClose
|
Good job! |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Fixed locking of PendingAddOp * Fixed stack overflow * Fixed stack overflow in different point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #3805
The test was failing because the updates to the object, done in the
initiate()method, were not immediately visible to other threads. We must use synchronized consistently in all the accesses.