Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we shutdown the bookie or retry when registration failure #3250

Closed
shoothzj opened this issue Apr 28, 2022 · 1 comment
Closed

Should we shutdown the bookie or retry when registration failure #3250

shoothzj opened this issue Apr 28, 2022 · 1 comment

Comments

@shoothzj
Copy link
Member

about the flaky test #3206

I have figured out why testBookieServerZKExpireBehaviour falky.

It's due to Registration task, bookie will retry to registration when zk session expires. If the registration fail, it will cause the bookie shutdown ExitCode.ZK_REG_FAIL.

@dlg99 @eolivelli @merlimat PTAL

@dlg99
Copy link
Contributor

dlg99 commented Jul 21, 2022

de-facto doc:

# ZooKeeper client session timeout in milliseconds
# Bookie server will exit if it received SESSION_EXPIRED because it
# was partitioned off from ZooKeeper for more than the session timeout
# JVM garbage collection, disk I/O will cause SESSION_EXPIRED.
# Increment this value could help avoiding this issue
zkTimeout=10000

BK will exit on SessionExpiredException from zk client; it is hard to recover from it (have to re-create the zk client + redo all initialization steps of all subcomponents) so better to exit and let k8s/supervisord restart the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants