Fix NPE in ComputationState constructor introduced by PR/7846

[drieber]

The root cause was assuming an empty transformUserNameToStateFamily map was passed, when instead null was passed.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---	---	---	---	---
Java
Python		---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

[drieber]

R: @reuvenlax

[ryan-williams]

Thanks for the quick fix here @drieber!

One question I had was why the Java_Examples_Dataflow precommit didn't run on #7846 (and so far doesn't seem to have run here)?

[drieber]

I don't know.

…

On Sun, Feb 17, 2019, 7:04 PM Ryan Williams ***@***.*** wrote: Thanks for the quick fix here @drieber <https://github.com/drieber>! One question I had was why the Java_Examples_Dataflow precommit didn't run on #7846 <#7846> (and so far doesn't seem to have run here)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7869 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT9x-qjJo9bL0c4XqE3a4mKyB8BEfghjks5vOhg0gaJpZM4a_9dw> .

[reuvenlax]

Run Dataflow ValidatesRunner

[reuvenlax]

Run Java PostCommit

[reuvenlax]

Run Java_Examples_Dataflow PreCommit

[reuvenlax]

@drieber thanks for the quick fix! For future reference, when changing a specific runner, it's best to run the ValidatesRunner tests for that runner before merging (see the run I triggered above for the Dataflow runner). Unfortunately the documentation on these trigger phrases is still a bit spotty.

[ryan-williams]

@reuvenlax per my comment above, do you know why "Java_Examples_Dataflow PreCommit" ran on our PRs (#7823, #7865) that didn't seem to have to do with Dataflow, but not #7846 (where the bug was introduced) nor here (where the bug was fixed)?

[reuvenlax]

Here is the trigger pattern (from job_PreCommit_Java_Examples_Dataflow.groovy <https://github.com/apache/beam/pull/6802/files#diff-29c78beae45d057dc4643ea33166a399> ) I think the path runners/google-cloud-dataflow in the trigger is incorrect. The actual code path is runners/dataflow. PrecommitJobBuilder builder = new PrecommitJobBuilder( scope: this, nameBase: 'Java_Examples_Dataflow', gradleTask: ':javaExamplesDataflowPreCommit', gradleSwitches: ['-PdisableSpotlessCheck=true'], // spotless checked in separate pre-commit triggerPathPatterns: [ '^model/.*$', '^sdks/java/.*$', '^runners/google-cloud-dataflow/.*$', '^examples/java/.*$', '^release/.*$', ] )

…

On Mon, Feb 18, 2019 at 1:16 PM Ryan Williams ***@***.***> wrote: @reuvenlax <https://github.com/reuvenlax> per my comment above <#7869 (comment)>, do you know why "Java_Examples_Dataflow PreCommit" ran on our PRs (#7823 <#7823>, #7865 <#7865>) that didn't seem to have to do with Dataflow, but not #7846 <#7846> (where the bug was introduced) nor here (where the bug was fixed)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7869 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUGE1XbjxbuXaeQHvqetViDggv7EpPCiks5vOxgegaJpZM4a_9dw> .