Attempt deserialize all non-standard portable logical types from proto

[Abacn]

Fixes #24870

• Fixes portable and not-yet-standard logical type get deserialized to UnknownLogicalType

Please add a meaningful description for your change here

This was broken by #23014 in particular, prior to the change, SchemaTransform sets the identifier of all not-yet-STANDARD logical types as "beam:logical_type:java_sdk:v1" when translating to proto

https://github.com/apache/beam/blob/release-2.42.0/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java#L183

after the change, it keeps URNs of portable logical types (identifier is a URN starts with "beam:logical_type:"). This enables translating them from another SDK.

https://github.com/apache/beam/blob/release-2.43.0/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java#L176

But, when translating back, the code here did not change accordingly:

beam/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java

Line 417 in f9a86e5

} else if (urn.equals(URN_BEAM_LOGICAL_JAVASDK)) {

Causing the deserialization not attempted and reduced to UnknownLogicalType.

Unfortunately Schema containing logical type with same identifier but different class is not considered equal, and is not caught by the unit test SchemaTranslationTest.FromProtoToProtoTest <- this could be a followup fix

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[Abacn]

There is a draft PR #23785 ran the use case of #24870 and succeeded: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/158/testReport/org.apache.beam.sdk.io.gcp.bigquery/BigQueryIOJsonIT/testDateType/

Ran without this change indeed failed: https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/156/testReport/org.apache.beam.sdk.io.gcp.bigquery/BigQueryIOJsonIT/testDateType/

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[Abacn]

CC: @ahmedabu98
CC: @kennknowles

[Abacn]

Run Java PreCommit

[Abacn]

all test succeeded, PTAL @kennknowles thanks!

[kennknowles]

Nice!

[kennknowles]

Will you open a cherry pick pull request as well?

[Abacn]

Will you open a cherry pick pull request as well?

Thanks!

opened #24925