-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow local packages in requirements.txt dependency list. #23684
Conversation
We pull these out and install them with the extra local packages infrastructure.
R: @chamikaramj |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #23684 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 720 720
Lines 96044 96076 +32
=======================================
+ Hits 70277 70305 +28
- Misses 24455 24459 +4
Partials 1312 1312
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
How is this different from using |
Because the user can place these directly inside their requirements file rather than listing them individually. This is particularly valuable for cross-language, or where one wants to keep the construction-time and execution-time environments in sync via a single file. |
Do we want to update the documentation to reflect this change? https://beam.apache.org/documentation/sdks/python-pipeline-dependencies/ |
Failure due to #21104 |
Run Python PreCommit |
Run Python_PVR_Flink PreCommit |
Good call. Updated the docs. |
@@ -50,6 +50,15 @@ | |||
* ([#X](https://github.com/apache/beam/issues/X)). | |||
--> | |||
|
|||
# [2.44.0] - Unreleased | |||
|
|||
## New Features / Improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a unit test for this feature ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
cc : @tvalentyn |
LGTM. Thanks. |
We pull these out and install them with the extra local packages infrastructure.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.