-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorRT Initial commit #22131
TensorRT Initial commit #22131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22131 +/- ##
==========================================
- Coverage 74.18% 73.99% -0.20%
==========================================
Files 706 714 +8
Lines 93229 93945 +716
==========================================
+ Hits 69159 69510 +351
- Misses 22802 23167 +365
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @ryanthompson591 for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
sdks/python/apache_beam/examples/inference/tensorrt_object_detection.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorrt_object_detection.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorrt_object_detection.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/inference/tensorrt_object_detection.py
Outdated
Show resolved
Hide resolved
gradle task for tensor RT example E2E test
Run Python 3.8 PostCommit |
sdks/python/apache_beam/examples/inference/tensorrt_object_detection.py
Outdated
Show resolved
Hide resolved
Run Python 3.8 PostCommit |
Pushed the suggestions, let's see if the tests pass. |
Run Python 3.8 PostCommit |
@@ -325,6 +325,8 @@ tasks.register("python38PostCommit") { | |||
dependsOn(":sdks:python:test-suites:direct:py38:postCommitIT") | |||
dependsOn(":sdks:python:test-suites:direct:py38:hdfsIntegrationTest") | |||
dependsOn(":sdks:python:test-suites:portable:py38:postCommitPy38") | |||
// TODO: https://github.com/apache/beam/issues/22651 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: @AnandInguva in Beam we typically mention a TODO, and then add a short description that follows the TODO. Full description can be in the TODO itself.
For example:
// TODO(#22651): Build docker image for tensor RT at runtime.
Also this todo seems a bit out of place here.
sdks/python/test-suites/containers/tensorrt_runinference/tensor_rt.dockerfile
Show resolved
Hide resolved
Run Python PreCommit |
1 similar comment
Run Python PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this, any further changes needed can come in a follow up PR
Good job everyone, and thanks @damccorm for the merge! |
Please add a meaningful description for your change here
Integration of TensorRT into Apache Beam.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @tvalentyn @AnandInguva @ryanthompson591 @yeandy
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.