Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorRT Initial commit #22131

Merged
merged 40 commits into from
Sep 16, 2022
Merged

Conversation

azhurkevich
Copy link
Contributor

@azhurkevich azhurkevich commented Jul 1, 2022

Please add a meaningful description for your change here
Integration of TensorRT into Apache Beam.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @tvalentyn @AnandInguva @ryanthompson591 @yeandy).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Jul 1, 2022
@azhurkevich azhurkevich changed the title Initial commit TensorRT Initial commit Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #22131 (2c417db) into master (48513ad) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22131      +/-   ##
==========================================
- Coverage   74.18%   73.99%   -0.20%     
==========================================
  Files         706      714       +8     
  Lines       93229    93945     +716     
==========================================
+ Hits        69159    69510     +351     
- Misses      22802    23167     +365     
  Partials     1268     1268              
Flag Coverage Δ
python 83.18% <0.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...am/examples/inference/tensorrt_object_detection.py 0.00% <0.00%> (ø)
...hon/apache_beam/ml/inference/tensorrt_inference.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/typehints/__init__.py 77.77% <0.00%> (-22.23%) ⬇️
...ks/python/apache_beam/runners/worker/statecache.py 89.69% <0.00%> (-6.47%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...dks/python/apache_beam/metrics/monitoring_infos.py 92.50% <0.00%> (-4.50%) ⬇️
...examples/inference/sklearn_mnist_classification.py 43.75% <0.00%> (-3.75%) ⬇️
sdks/python/apache_beam/internal/pickler.py 92.00% <0.00%> (-3.46%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 76.66% <0.00%> (-3.05%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @ryanthompson591 for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@yeandy
Copy link
Contributor

yeandy commented Jul 8, 2022

R: @yeandy @AnandInguva @tvalentyn

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@AnandInguva
Copy link
Contributor

Run Python 3.8 PostCommit

@github-actions github-actions bot added the build label Sep 7, 2022
@yeandy
Copy link
Contributor

yeandy commented Sep 8, 2022

Run Python 3.8 PostCommit

@tvalentyn
Copy link
Contributor

I took a closer look, see suggestions. I haven't tested it.

Pushed the suggestions, let's see if the tests pass.

@AnandInguva
Copy link
Contributor

Run Python 3.8 PostCommit

@@ -325,6 +325,8 @@ tasks.register("python38PostCommit") {
dependsOn(":sdks:python:test-suites:direct:py38:postCommitIT")
dependsOn(":sdks:python:test-suites:direct:py38:hdfsIntegrationTest")
dependsOn(":sdks:python:test-suites:portable:py38:postCommitPy38")
// TODO: https://github.com/apache/beam/issues/22651
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: @AnandInguva in Beam we typically mention a TODO, and then add a short description that follows the TODO. Full description can be in the TODO itself.

For example:

// TODO(#22651): Build docker image for tensor RT at runtime.

Also this todo seems a bit out of place here.

@damccorm
Copy link
Contributor

Run Python PreCommit

1 similar comment
@damccorm
Copy link
Contributor

Run Python PreCommit

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this, any further changes needed can come in a follow up PR

@damccorm damccorm merged commit a8ca305 into apache:master Sep 16, 2022
@yeandy
Copy link
Contributor

yeandy commented Sep 16, 2022

Good job everyone, and thanks @damccorm for the merge!

@azhurkevich azhurkevich deleted the tensorrt_runinference branch September 27, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants