-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pydoc rendering for annotated classes #22121
Conversation
* Do not assemble target class into a func which messes up doc generating
Codecov Report
@@ Coverage Diff @@
## master #22121 +/- ##
==========================================
+ Coverage 74.19% 74.25% +0.06%
==========================================
Files 701 701
Lines 92687 92889 +202
==========================================
+ Hits 68767 68974 +207
+ Misses 22654 22649 -5
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Refactored in a way similar to pypi's deprecated package. This resolves missing constructor documentation in pydoc, for example, in mangodbio, in GroupIntoBatches. (Precommit fails on known flake R: @johnjcasey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Run Python PreCommit |
The failed test is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
R: @tvalentyn |
Thanks! Out of scope, but it may be possible to also alter docstring ( |
Thanks. Sounds good. Filed #22265 |
Fixes #21555
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.