Add sdk_harness_log_level_overrides option for python sdk #22077
Conversation
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #22077 +/- ##
==========================================
- Coverage 74.00% 74.00% -0.01%
==========================================
Files 703 703
Lines 92936 92955 +19
==========================================
+ Hits 68774 68787 +13
- Misses 22896 22902 +6
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| 'For example, by specifying the value "{\"a.b.c\":\"DEBUG\"}, ' | ||
| 'the logger underneath the module "a.b.c" will be configured to ' | ||
| 'output logs at the DEBUG level. Similarly, by specifying the ' | ||
| 'value {"a.b.c":"WARNING"} all loggers underneath the "a.b.c" ' |
There was a problem hiding this comment.
is escaping quotes necessary here as well?
There was a problem hiding this comment.
yeah, not necessary. Copied from java sdk and found I even missed a quote mark. Will fix
| parsed_overrides.update(line) | ||
| except Exception: | ||
| _LOGGER.error( | ||
| "Unable to parse sdk_harness_log_level_overrides. " |
There was a problem hiding this comment.
Maybe print the line that cannot be parsed here?
Co-authored-by: tvalentyn <[email protected]>
|
The Workflow run is cancelling this PR. It is an earlier duplicate of 1729654 run. |
|
The Workflow run is cancelling this PR. It is an earlier duplicate of 2083803 run. |
|
@tvalentyn PTAL |
|
Thanks a lot, @Abacn , very nice. |
Fixes #18222
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.