[BEAM-1259] Use the warning module in typecoders to log only the first occurrence… #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of each typehint related warning message.
|
Refer to this link for build results (access rights to CI server needed): |
|
Could you update the title to actually point to a JIRA issue (e.g. [BEAM-xyz] for the issue #xyz)? And also please explain the reason for change either in the PR or in the linked jira issue. Otherwise looks good. |
N3da
changed the title
|
Done. |
|
LGTM. R: @robertwb |
|
This has been merged, could you please close it? (Apache doesn't give us write access to the repo to do so ourselves...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of each typehint related warning message.