Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Run some BigQuery integration tests only on one Dataflow Python3.X PostCommit #23573

Closed
Abacn opened this issue Oct 11, 2022 · 8 comments

Comments

@Abacn
Copy link
Contributor

Abacn commented Oct 11, 2022

What needs to happen?

There is a Dataflow Python PostCommit flake due to too many BigQuery tests running same time.
Encountered in recent release process: #23200 (comment)

I've found that trying to run all the dataflow based tests simultaneously simply causes spurious failures in
various levels of API quota. apache-beam-testing simply can't do them all at the same time. 

and also observed in #23014 (comment)

Python3.x PostCommit has been timed out (4 h limit) with high probability. The most time consuming testing module is BigQuery which costs 2 h run time. As we are going to support python3.10, quota issue is going to be worse.

We should audit the current BigQuery integration tests on Dataflow to see if running on single py verision suffices (as we did for spannerIOIT), and redistribute these tests.

Issue Priority

Priority: 1

Issue Component

Component: test-failures

@Abacn
Copy link
Contributor Author

Abacn commented Oct 11, 2022

.take-issue

@Abacn
Copy link
Contributor Author

Abacn commented Oct 11, 2022

add-labels python, io, gcp

@Abacn
Copy link
Contributor Author

Abacn commented Oct 12, 2022

Considered as a subtask of #20930

@AnandInguva
Copy link
Contributor

.add-labels python, io, gcp

@github-actions
Copy link
Contributor

Label cannot be managed because it does not exist in the repo. Please check your spelling.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2022

Currently on hold as GitHub migration involves splitting postcommit tests. Downgrade to P2 for tracking if it still occurs when GitHub migration completed.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2022

.remove-labels P1

.add-labels P2

@github-actions github-actions bot added P2 and removed P1 labels Oct 18, 2022
@Abacn
Copy link
Contributor Author

Abacn commented Apr 4, 2023

let me close this. Superseded by #25970 which will reduce the run time of Python Postcommit by an hour

@Abacn Abacn closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants