Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Make pydoc docstring reflecting deprecated and experimental API #22265

Open
Abacn opened this issue Jul 13, 2022 · 14 comments
Open

[Task]: Make pydoc docstring reflecting deprecated and experimental API #22265

Abacn opened this issue Jul 13, 2022 · 14 comments

Comments

@Abacn
Copy link
Contributor

Abacn commented Jul 13, 2022

What needs to happen?

When @deprecated() and @experimental() decorators are used, it may be possible to also alter docstring (__doc__) so that it is reflected in autogenerated sphinx docs. Similar to that TF is doing this here: https://github.com/tensorflow/tensorflow/blob/e4dbcc5732be1914b5dad205c2b1eabc040aafc4/tensorflow/python/util/deprecation.py#L372

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core

@Abacn
Copy link
Contributor Author

Abacn commented Jul 14, 2022

.add-labels website
.remove-labels core, 'awaiting triage'

@github-actions
Copy link
Contributor

Label website
.remove-labels cannot be managed because it does not exist in the repo. Please check your spelling.

@tvalentyn
Copy link
Contributor

.remove-labels cannot be managed because it does not exist in the repo. Please check your spelling.

@damccorm do you know the right command by chance?

@github-actions
Copy link
Contributor

Label cannot cannot be managed because it does not exist in the repo. Please check your spelling.

@damccorm
Copy link
Contributor

Hm, I think the bot doesn't handle new lines correctly. Moving it to one line will probably resolve it? I'll check:

.add-labels website .remove-labels core,'awaiting triage'

@damccorm
Copy link
Contributor

(to be clear, this is a bug that should be fixed)

@damccorm
Copy link
Contributor

Oh, there may also be an ordering issue with multiple commands? Idk, I'll look into it, I filed #22269

.add-labels website

@tvalentyn
Copy link
Contributor

.add-labels website

@tvalentyn
Copy link
Contributor

I see. thanks for looking into it!

@Abacn
Copy link
Contributor Author

Abacn commented Aug 3, 2022

.add-labels "good first issue"

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Label "good cannot be managed because it does not exist in the repo. Please check your spelling.

@Abacn
Copy link
Contributor Author

Abacn commented Aug 3, 2022

.add-labels good_first_issue

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Label good_first_issue cannot be managed because it does not exist in the repo. Please check your spelling.

@Abacn
Copy link
Contributor Author

Abacn commented Aug 3, 2022

.add-labels 'good first issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants