Merge pull request #23578: Remove artificial timeout in FirestoreV1IT…

…, Dataflow runner is very slow
apache · Oct 13, 2022 · 2d84233 · 2d84233
2 parents d30ecda + b681a63
commit 2d84233
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/...cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/it/BaseFirestoreIT.java b/...cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/it/BaseFirestoreIT.java
@@ -62,7 +62,6 @@
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TestName;
-import org.junit.rules.Timeout;
 
 @SuppressWarnings({
   "initialization.fields.uninitialized",
@@ -76,19 +75,13 @@ abstract class BaseFirestoreIT {
   @Rule(order = 1)
   public final TestName testName = new TestName();
 
-  @Rule(
-      order =
-          2) // ensure our helper is "outer" to the timeout so we are allowed to cleanup even if a
-  // test times out
+  @Rule(order = 2)
   public final FirestoreTestingHelper helper = new FirestoreTestingHelper(CleanupMode.ALWAYS);
 
   @Rule(order = 3)
-  public final Timeout timeout = new Timeout(10, TimeUnit.MINUTES);
-
-  @Rule(order = 4)
   public final TestPipeline testPipeline = TestPipeline.create();
 
-  @Rule(order = 5)
+  @Rule(order = 4)
   public final TestPipeline testPipeline2 = TestPipeline.create();
 
   protected static final RpcQosOptions RPC_QOS_OPTIONS =