From 6a7803a7792cc68662bd3fd22d9091ba51acab46 Mon Sep 17 00:00:00 2001 From: Bryce Mecum Date: Mon, 2 Dec 2024 20:50:35 -0800 Subject: [PATCH 1/5] Remove badges --- r/README.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/r/README.md b/r/README.md index 8601afe492b99..35327c5b3c330 100644 --- a/r/README.md +++ b/r/README.md @@ -1,14 +1,5 @@ # arrow - - -[![cran](https://www.r-pkg.org/badges/version-last-release/arrow)](https://cran.r-project.org/package=arrow) -[![CI](https://github.com/apache/arrow/workflows/R/badge.svg?event=push)](https://github.com/apache/arrow/actions?query=workflow%3AR+branch%3Amain+event%3Apush) -[![R-universe status badge](https://apache.r-universe.dev/badges/arrow)](https://apache.r-universe.dev) -[![conda-forge](https://img.shields.io/conda/vn/conda-forge/r-arrow.svg)](https://anaconda.org/conda-forge/r-arrow) - - - ## Overview The R `{arrow}` package provides access to many of the features of the [Apache Arrow C++ library](https://arrow.apache.org/docs/cpp/index.html) for R users. The goal of arrow is to provide an Arrow C++ backend to `{dplyr}`, and access to the Arrow C++ library through familiar base R and tidyverse functions, or `{R6}` classes. The dedicated R package website is located [here](https://arrow.apache.org/docs/r/index.html). From e00ce4d3873c9e39f110e32251cd2868758d8ad7 Mon Sep 17 00:00:00 2001 From: Bryce Mecum Date: Mon, 2 Dec 2024 21:02:50 -0800 Subject: [PATCH 2/5] Update NEWS.md headers We skipped 18.0.0 and did our first 18.X CRAN release with 18.1.0 so we shouldn't have an 18.0.0 header. --- r/NEWS.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/r/NEWS.md b/r/NEWS.md index 895df5c61997a..021652e7476a7 100644 --- a/r/NEWS.md +++ b/r/NEWS.md @@ -18,6 +18,16 @@ --> # arrow 18.1.0 +# arrow 18.1.0.9000 + +## Minor improvements and fixes + +* Fix bindings to allow filtering a factor column in a Dataset using `%in%` (#43446) +* Update `str_sub` binding to properly handle negative `end` values (@coussens, #44141) +* Fix altrep string columns from readr (#43351) +* Fix crash in ParquetFileWriter$WriteTable and add WriteBatch (#42241) +* Fix bindings in Math group generics (@aboyoun, #43162) +* Fix pull on a grouped query returns the wrong column (#43172) # arrow 17.0.0 From 575cbddaa6c63ad20e58b3991369d1663a3d2cf8 Mon Sep 17 00:00:00 2001 From: Bryce Mecum Date: Fri, 1 Nov 2024 07:58:33 -0700 Subject: [PATCH 3/5] GH-43547: [R][CI] Add recheck workflow for checking reverse dependencies on GHA (#43784) ### Rationale for this change See https://github.com/apache/arrow/issues/43547. ### What changes are included in this PR? Adds two new new crossbow tasks for performing reverse dependency checking using https://github.com/r-devel/recheck: - `r-recheck-most` - `r-recheck-strong` ### Are these changes tested? Yes. https://github.com/apache/arrow/pull/44523#issuecomment-2434122461. ### Are there any user-facing changes? No. * GitHub Issue: #43547 Fixes https://github.com/apache/arrow/issues/43547. Authored-by: Bryce Mecum Signed-off-by: Bryce Mecum --- dev/tasks/r/github.recheck.yml | 30 ++++++++++++++++++++++++++++++ dev/tasks/tasks.yml | 15 +++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 dev/tasks/r/github.recheck.yml diff --git a/dev/tasks/r/github.recheck.yml b/dev/tasks/r/github.recheck.yml new file mode 100644 index 0000000000000..5f0095fa22126 --- /dev/null +++ b/dev/tasks/r/github.recheck.yml @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +{% import 'macros.jinja' as macros with context %} + +{{ macros.github_header() }} + +jobs: + recheck: + name: Reverse check {{ which }} dependents + uses: r-devel/recheck/.github/workflows/recheck.yml@9fe04de60ebeadd505b8d76223a346617ccca836 + with: + which: {{ which }} + subdirectory: r + repository: {{ arrow.github_repo }} + ref: {{ arrow.branch }} diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml index 91e1c07e1fc20..9281cb1d0650d 100644 --- a/dev/tasks/tasks.yml +++ b/dev/tasks/tasks.yml @@ -94,6 +94,7 @@ groups: r: - test*-r-* - r-binary-packages + - r-recheck-most ruby: - test-*ruby* @@ -901,6 +902,20 @@ tasks: - r-pkg__bin__macosx__big-sur-arm64__contrib__4.3__arrow_{no_rc_r_version}\.tgz - r-pkg__src__contrib__arrow_{no_rc_r_version}\.tar\.gz +{% for which in ["strong", "most"] %} + # strong and most used here are defined by ?tools::package_dependencies as: + # + # strong: Depends, Imports, LinkingTo + # most: Depends, Imports, LinkingTo, Suggests + # + # So the key difference between strong and most is whether you want to expand + # the reverse dependency checking to Suggests (most) or not. + r-recheck-{{which}}: + ci: github + template: r/github.recheck.yml + params: + which: {{which}} +{% endfor %} ########################### Release verification ############################ From cb8b0f3b5db9f8c9c11fbd0de7d2c8068ee2d7fa Mon Sep 17 00:00:00 2001 From: Bryce Mecum Date: Tue, 3 Dec 2024 19:55:30 -0800 Subject: [PATCH 4/5] Make sed call in update-checksums.R crossplat --- r/tools/update-checksums.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/r/tools/update-checksums.R b/r/tools/update-checksums.R index f41652e87849e..ceb838a63b21e 100644 --- a/r/tools/update-checksums.R +++ b/r/tools/update-checksums.R @@ -62,7 +62,7 @@ for (path in binary_paths) { if (grepl("windows", path)) { cat(paste0("Converting ", path, " to windows style line endings\n")) # UNIX style line endings cause errors with mysys2 sha512sum - sed_status <- system2("sed", args = c("-i", "s/\\\\r//", file)) + sed_status <- system2("sed", args = c("-i", "-e", "s/\\\\r//", file)) if (sed_status != 0) { stop("Failed to remove \\r from windows checksum file. Exit code: ", sed_status) } From 151becb0cfb94a0ef5a0e26928a2527f389d31ce Mon Sep 17 00:00:00 2001 From: Bryce Mecum Date: Wed, 4 Dec 2024 14:09:18 -0800 Subject: [PATCH 5/5] Fix news header --- r/NEWS.md | 1 - 1 file changed, 1 deletion(-) diff --git a/r/NEWS.md b/r/NEWS.md index 021652e7476a7..5ea477bf6f19c 100644 --- a/r/NEWS.md +++ b/r/NEWS.md @@ -18,7 +18,6 @@ --> # arrow 18.1.0 -# arrow 18.1.0.9000 ## Minor improvements and fixes