Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35627: [C++][Format][Integration] Add string view to the arrow format #35628

Closed
wants to merge 38 commits into from
Closed

GH-35627: [C++][Format][Integration] Add string view to the arrow format #35628

wants to merge 38 commits into from

Commits on Jun 15, 2023

  1. Draft basic scaffolding for Binary/StringView types and get compiling

    @wesm @bkietz
    wesm authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6d490ef View commit details
    Browse the repository at this point in the history

  2. BinaryViewBuilder: fix duplicate values in null bitmap

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    21688eb View commit details
    Browse the repository at this point in the history

  3. enable JSON converter for StringView/BinaryView

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6b6cd95 View commit details
    Browse the repository at this point in the history

  4. add StringView/BinaryView to AllTypeIds

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    52eb446 View commit details
    Browse the repository at this point in the history

  5. implement inline visitor for StringView/BinaryView

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8a75259 View commit details
    Browse the repository at this point in the history

  6. fix formatting

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1d81aea View commit details
    Browse the repository at this point in the history

  7. fix formatting

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    3931e25 View commit details
    Browse the repository at this point in the history

  8. run binary data visitor tests on StringView/BinaryView

    @zagto @bkietz
    zagto authored and bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    7fe8e2d View commit details
    Browse the repository at this point in the history

  9. fixes in substrait, rename in LICENSE, owning scalars

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6624acc View commit details
    Browse the repository at this point in the history

  10. delete potentially internal viewing members for rvalues

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8511bf1 View commit details
    Browse the repository at this point in the history

  11. Added validation for StringView arrays

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6df010f View commit details
    Browse the repository at this point in the history

  12. Adding comparison and concatenation

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5c24fd5 View commit details
    Browse the repository at this point in the history

  13. wrote <=, needed >=

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    190648c View commit details
    Browse the repository at this point in the history

  14. Extract visitation of views owning buffers

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    018b49f View commit details
    Browse the repository at this point in the history

  15. add cast to/from string_view

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0ee9d89 View commit details
    Browse the repository at this point in the history

  16. Adding IPC serde of views by converting to/from dense strings

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6ed4ac0 View commit details
    Browse the repository at this point in the history

  17. initial attempt at indices/offsets repr in arrow

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a8bf258 View commit details
    Browse the repository at this point in the history

  18. formatting, compilation fixes

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    bfe16b3 View commit details
    Browse the repository at this point in the history

  19. CI fixes

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1a01463 View commit details
    Browse the repository at this point in the history

  20. format python too

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    bdf7836 View commit details
    Browse the repository at this point in the history

  21. more casts

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    80a8758 View commit details
    Browse the repository at this point in the history

  22. msvc: more casts

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4cd23f2 View commit details
    Browse the repository at this point in the history

  23. Extend R converter with binary view support

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2d93d97 View commit details
    Browse the repository at this point in the history

  24. more casts

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2c395c3 View commit details
    Browse the repository at this point in the history

  25. read/write hex encode prefix for string view too

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e626949 View commit details
    Browse the repository at this point in the history

  26. review comments re: Columnar.rst description

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    71db0dc View commit details
    Browse the repository at this point in the history

  27. msvc: explicit unreachable switch default

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c961942 View commit details
    Browse the repository at this point in the history

  28. r: exclude decimal from binary_like

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    84f0723 View commit details
    Browse the repository at this point in the history

  29. go impl isn't here... yet

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    175baac View commit details
    Browse the repository at this point in the history

  30. add benchmarks for filter, take, sort

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b5196a6 View commit details
    Browse the repository at this point in the history

  31. clang-format

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    dd4a5be View commit details
    Browse the repository at this point in the history

  32. msvc: doesn't have constexpr conversion operator?

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    aaad04f View commit details
    Browse the repository at this point in the history

  33. try fix for opentelemetry build failure

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d71c223 View commit details
    Browse the repository at this point in the history

  34. review comments

    @bkietz
    bkietz committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5f06a1c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. repair merge error

    @bkietz
    bkietz committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    def55c6 View commit details
    Browse the repository at this point in the history

  2. formatting again

    @bkietz
    bkietz committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    dddc3df View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. DCHECK_EQ() not DCHECK(==)

    @bkietz
    bkietz committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    fdda27c View commit details
    Browse the repository at this point in the history

  2. add BinaryViewLike matcher

    @bkietz
    bkietz committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    46cf7e6 View commit details
    Browse the repository at this point in the history