Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15001: [R] Fix Parquet datatype test failure #15197

Merged
merged 4 commits into from
Jan 5, 2023
Merged

GH-15001: [R] Fix Parquet datatype test failure #15197

merged 4 commits into from
Jan 5, 2023

Conversation

wjones127
Copy link
Member

@wjones127 wjones127 commented Jan 4, 2023 •
edited by github-actions bot
Loading

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

@wjones127
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Revision: 821f24c

Submitted crossbow builds: ursacomputing/crossbow @ actions-727114207a

Task Status
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-r41 Azure
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions
r-binary-packages Github Actions
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-dev-duckdb Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-gcc-12 Github Actions
test-r-install-local Github Actions
test-r-install-local-minsizerel Github Actions
test-r-library-r-base-latest Azure
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rstudio-r-base-4.1-opensuse153 Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 Github Actions
test-r-versions Github Actions
test-ubuntu-18.04-r-sanitizer Azure

@paleolimbot
Copy link
Member

Thanks Will + Jon!

FWIW, this started failing for me too when I updated my R version to 4.2.2. I wonder if our docker images are updating the R version at varying frequencies? (Or maybe it's totally unrelated).

@jonkeane
Copy link
Member

jonkeane commented Jan 5, 2023

FWIW, this started failing for me too when I updated my R version to 4.2.2. I wonder if our docker images are updating the R version at varying frequencies? (Or maybe it's totally unrelated).

I think the version update + docker images are both probably redherrings. The original (and honestly even the current) way that these tests were/are skipped was/is very sensitive to slight differences in your dev env + location of running. As far as I could tell: the tests themselves would never pass if the fixtures were found — so any passing was actually a symptom of skipping

@jonkeane jonkeane marked this pull request as ready for review January 5, 2023 17:01
jonkeane
jonkeane approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these test fixups!

@jonkeane jonkeane merged commit d4a0c9e into apache:master Jan 5, 2023
@wjones127
Copy link
Member Author

@jonkeane I think the test was still skipped

https://github.com/apache/arrow/actions/runs/3847573332/jobs/6554198668#step:9:9689

Did you see it run in one of the CI jobs?

@jonkeane
Copy link
Member

jonkeane commented Jan 5, 2023

Ack, you're right. I had seen it run, but it must have been a prior run and not that latest one. I'll make an issue + send a PR I think I know what the issue is.

@jonkeane jonkeane mentioned this pull request Jan 5, 2023
Merged
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
@wjones127 @jonkeane @EpsilonPrime
apacheGH-15001: [R] Fix Parquet datatype test failure (apache#15197)
2c87fdc 
* Closes: apache#15001

Lead-authored-by: Will Jones <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
@ursabot
Copy link

ursabot commented Jan 6, 2023

Benchmark runs are scheduled for baseline = 040310f and contender = d4a0c9e. d4a0c9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️4.75% ⬆️3.1%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.51% ⬆️0.1%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d4a0c9e8 ec2-t3-xlarge-us-east-2
[Finished] d4a0c9e8 test-mac-arm
[Finished] d4a0c9e8 ursa-i9-9960x
[Finished] d4a0c9e8 ursa-thinkcentre-m75q
[Finished] 040310fe ec2-t3-xlarge-us-east-2
[Failed] 040310fe test-mac-arm
[Finished] 040310fe ursa-i9-9960x
[Finished] 040310fe ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jonkeane added a commit that referenced this pull request Jan 6, 2023
@jonkeane
GH-15205: [R] Fix a parquet-fixture finding in R tests (#15207)
6bd847b 
A follow on to #15197 where we actually force these tests when the force-tests job is run + make sure that we look at the root of the filesystem for the fixtures
* Closes: #15205

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Jan 9, 2023
@wjones127 @jonkeane @vibhatha
apacheGH-15001: [R] Fix Parquet datatype test failure (apache#15197)
0ce7015 
* Closes: apache#15001

Lead-authored-by: Will Jones <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Jan 9, 2023
@jonkeane @vibhatha
apacheGH-15205: [R] Fix a parquet-fixture finding in R tests (apache#…
cae05dd 
…15207)

A follow on to apache#15197 where we actually force these tests when the force-tests job is run + make sure that we look at the root of the filesystem for the fixtures
* Closes: apache#15205

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 10, 2023
@jonkeane @EpsilonPrime
apacheGH-15205: [R] Fix a parquet-fixture finding in R tests (apache#…
c64ac16 
…15207)

A follow on to apache#15197 where we actually force these tests when the force-tests job is run + make sure that we look at the root of the filesystem for the fixtures
* Closes: apache#15205

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkeane jonkeane jonkeane approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R] Map/list equality tests are failing only on the sanitizer nightlies
4 participants
@wjones127 @paleolimbot @jonkeane @ursabot