diff --git a/cpp/src/arrow/compute/kernels/aggregate_test.cc b/cpp/src/arrow/compute/kernels/aggregate_test.cc index c7909487fb3e6..8f400b2d249a2 100644 --- a/cpp/src/arrow/compute/kernels/aggregate_test.cc +++ b/cpp/src/arrow/compute/kernels/aggregate_test.cc @@ -2532,6 +2532,7 @@ template void CheckModes(const Datum& array, const ModeOptions options, const std::vector& expected_modes, const std::vector& expected_counts) { + ARROW_SCOPED_TRACE("Mode Options: ", options.ToString()); ASSERT_OK_AND_ASSIGN(Datum out, Mode(array, options)); ValidateOutput(out); const StructArray out_array(out.array()); @@ -2543,7 +2544,9 @@ void CheckModes(const Datum& array, const ModeOptions options, for (int i = 0; i < out_array.length(); ++i) { // equal or nan equal ASSERT_TRUE((expected_modes[i] == out_modes[i]) || - (expected_modes[i] != expected_modes[i] && out_modes[i] != out_modes[i])); + (expected_modes[i] != expected_modes[i] && out_modes[i] != out_modes[i])) + << " Actual Value: " << out_modes[i] << "\n" + << "Expected Value: " << expected_modes[i]; ASSERT_EQ(expected_counts[i], out_counts[i]); } } @@ -2552,6 +2555,7 @@ template <> void CheckModes(const Datum& array, const ModeOptions options, const std::vector& expected_modes, const std::vector& expected_counts) { + ARROW_SCOPED_TRACE("Mode Options: ", options.ToString()); ASSERT_OK_AND_ASSIGN(Datum out, Mode(array, options)); ValidateOutput(out); const StructArray out_array(out.array()); @@ -2561,7 +2565,7 @@ void CheckModes(const Datum& array, const ModeOptions options, const uint8_t* out_modes = out_array.field(0)->data()->GetValues(1); const int64_t* out_counts = out_array.field(1)->data()->GetValues(1); for (int i = 0; i < out_array.length(); ++i) { - ASSERT_TRUE(expected_modes[i] == bit_util::GetBit(out_modes, i)); + ASSERT_EQ(expected_modes[i], bit_util::GetBit(out_modes, i)); ASSERT_EQ(expected_counts[i], out_counts[i]); } } @@ -3337,6 +3341,7 @@ class TestPrimitiveQuantileKernel : public ::testing::Test { for (size_t i = 0; i < this->interpolations_.size(); ++i) { options.interpolation = this->interpolations_[i]; + ARROW_SCOPED_TRACE("Quantile Options: ", options.ToString()); ASSERT_OK_AND_ASSIGN(Datum out, Quantile(array, options)); const auto& out_array = out.make_array(); @@ -3351,7 +3356,9 @@ class TestPrimitiveQuantileKernel : public ::testing::Test { const auto& numeric_scalar = checked_pointer_cast(expected[j][i].scalar()); ASSERT_TRUE((quantiles[j] == numeric_scalar->value) || - (std::isnan(quantiles[j]) && std::isnan(numeric_scalar->value))); + (std::isnan(quantiles[j]) && std::isnan(numeric_scalar->value))) + << " Actual Value: " << quantiles[j] << "\n" + << "Expected Value: " << numeric_scalar->value; } } else { AssertTypeEqual(out_array->type(), type_singleton());