Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17281: [C++] Fix cache size reporting on Windows #13813

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

cyb70289
Copy link
Contributor

@cyb70289 cyb70289 commented Aug 8, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you get a chance to try on an actual machine?

@cyb70289
Copy link
Contributor Author

cyb70289 commented Aug 9, 2022

I tested on an i7-1165 laptop with 4 cores x 2 hyperthreads.
It reports four L1 cache with 48K in size, and another four L1 cache with 32K in size.
Original code reports totally 320K, the PR reports 48K.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit b83da3f into apache:master Aug 9, 2022
@cyb70289 cyb70289 deleted the 17281-cpuinfo-cache-win branch August 9, 2022 06:05
@ursabot
Copy link

ursabot commented Aug 9, 2022

Benchmark runs are scheduled for baseline = 71af8d8 and contender = b83da3f. b83da3f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.27% ⬆️0.07%] test-mac-arm
[Finished ⬇️1.09% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.71% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b83da3fc ec2-t3-xlarge-us-east-2
[Finished] b83da3fc test-mac-arm
[Finished] b83da3fc ursa-i9-9960x
[Finished] b83da3fc ursa-thinkcentre-m75q
[Finished] 71af8d8f ec2-t3-xlarge-us-east-2
[Finished] 71af8d8f test-mac-arm
[Finished] 71af8d8f ursa-i9-9960x
[Finished] 71af8d8f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants