ARROW-11722: [Rust] Improve error message in FFI cast. #9540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9540 +/- ##
==========================================
- Coverage 82.29% 82.28% -0.01%
==========================================
Files 244 244
Lines 55616 55616
==========================================
- Hits 45767 45766 -1
- Misses 9849 9850 +1
Continue to review full report at Codecov.
|
Dandandan
reviewed
Feb 21, 2021
Commit suggestion. Co-authored-by: Daniël Heres <[email protected]>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
While trying to cast from pyarrow to rust I encountered the following error message: `CDataInterface("The datatype \"{}\" is still not supported in Rust implementation")`, which is not very informative.
This PR is very small and prints the datatype format passed to the function in the error message.
Closes apache#9540 from ritchie46/improve_ffi_error
Authored-by: Ritchie Vink <[email protected]>
Signed-off-by: Andrew Lamb <[email protected]>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
While trying to cast from pyarrow to rust I encountered the following error message: `CDataInterface("The datatype \"{}\" is still not supported in Rust implementation")`, which is not very informative.
This PR is very small and prints the datatype format passed to the function in the error message.
Closes apache#9540 from ritchie46/improve_ffi_error
Authored-by: Ritchie Vink <[email protected]>
Signed-off-by: Andrew Lamb <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9540 +/- ##
==========================================
- Coverage 82.29% 82.28% -0.01%
==========================================
Files 244 244
Lines 55616 55616
==========================================
- Hits 45767 45766 -1
- Misses 9849 9850 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to cast from pyarrow to rust I encountered the following error message:
CDataInterface("The datatype \"{}\" is still not supported in Rust implementation"), which is not very informative.This PR is very small and prints the datatype format passed to the function in the error message.